Fix #6374 - Render.com web builds fail #6375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@simoncrypta I've assigned you as you are assigned to the issue - thought we should be consistent ( and maybe double check the bot?) |
Contributor
|
@shansmith01 Thanks for that ! This cause so much trouble for everyone and this trick is not really well documented. So since we use yarn 3 by default, we should also skip dep sync for Render by default. Good job ! @noire-munich All right, I will check if we can update the bot for that. 🙂 |
1 task
simoncrypta
suggested changes
Sep 13, 2022
Co-authored-by: Simon Gagnon <[email protected]>
simoncrypta
approved these changes
Sep 13, 2022
Contributor
simoncrypta
left a comment
simoncrypta
left a comment
There was a problem hiding this comment.
Works like a charm, thanks a lot !
jtoar
pushed a commit
that referenced
this pull request
Sep 14, 2022
* Update render.js * Update packages/cli/src/commands/setup/deploy/templates/render.js Co-authored-by: Simon Gagnon <[email protected]> Co-authored-by: Simon Gagnon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6374 re Render.com web build fails due to only supporting yarn 1.
Updated the template file so others don't have the same issue